-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unneeded rescan when importing transactions in chunk #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfauvel
approved these changes
Oct 22, 2024
jpraynaud
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
dlachaume
approved these changes
Oct 22, 2024
Alenar
force-pushed
the
djo/2021/tx-chunk-importer_avoid-uneeded-rescan
branch
3 times, most recently
from
October 22, 2024 10:30
e0a921a
to
b513d9a
Compare
Alenar
temporarily deployed
to
testing-preview
October 22, 2024 10:50
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 22, 2024 10:50
— with
GitHub Actions
Inactive
Alenar
force-pushed
the
djo/2021/tx-chunk-importer_avoid-uneeded-rescan
branch
from
October 22, 2024 12:48
b513d9a
to
1b6e982
Compare
…ackward` This will allow to return the latest chain point known by the cardano block scanner. Else we only know it when there's a roll foward.
…chunk This fix the issue of importing when there's no transactions to store in a large range of blocks: * Instead of always using the database to get the start point the db is only used for the first chunk. * For subsequent call the last chain point polled by the streamer is used.
Alenar
force-pushed
the
djo/2021/tx-chunk-importer_avoid-uneeded-rescan
branch
from
October 22, 2024 14:06
1b6e982
to
5f04634
Compare
* mithril-aggregator from `0.5.87` to `0.5.88` * mithril-common from `0.4.72` to `0.4.73` * mithril-signer from `0.2.202` to `0.2.203`
Alenar
force-pushed
the
djo/2021/tx-chunk-importer_avoid-uneeded-rescan
branch
from
October 22, 2024 14:47
5f04634
to
84ca63f
Compare
Alenar
temporarily deployed
to
testing-preview
October 22, 2024 14:56
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
October 22, 2024 14:56
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR fix the issue described in #2021.
To do so the way that the importer obtains its starting point change:
ChainPoint
that was polled by its block streamer after each import, so it can be used as the next import start point, solving the issue.Curated logs from the e2e before the change
The same start block number is used repeatedly
Curated logs from the e2e after the change
No start block number is used more than once
Pre-submit checklist
Issue(s)
Closes #2021